WordPress Affiliate Manager › Forums › Affiliate Manager Plugin › some minor issues i18N
- This topic has 2 replies, 2 voices, and was last updated 7 years, 10 months ago by
mbrsolution.
-
AuthorPosts
-
May 31, 2018 at 10:49 pm #3658
Jim
ParticipantHi Shadow Labs, mbrsolution,
I wanna thank you and the whole WPAM team for the plugin. The plugin is going to solve the business problem on our site.
During the integration testing, we’ve found some minor issues and would like to report to you so they can be addressed in future releases:
i18N: a few places are not i18N ready and localization can’t completely rely on the .pot file and will require code changes to the plugin. They are storefront texts, and localization of them is required for any other non-English language:
1. “to” on line 31 of transaction_table.php – add a call to _e() around the “to” label
2. “Email Address” on line 311 in Plugin.php is calling __() but missed the plugin name. The corrected code would look like this:
‘label_username’ => __(‘Email Address’, ‘affiliates-manager’)3. Similar issue with the following two messages in DatabaseInnstaller.php – fixed code:
$msg->content = __(“Thank you. Your registration is now complete. You can log into the affiliate area and begin promoting.”, ‘affiliates-manager’);
$msg->content = __(“Your affiliate account for {blogname} has been approved!. \n\nUsername: {affusername} \nPassword: {affpassword} \nLogin URL: {affloginurl} \n\nPlease log into your account to get referral code.”, ‘affiliates-manager’);4. Country codes, and state codes are not i18N ready. They are defined as public static $countryCodes = array() which prevents __() from being added, and accepted for the codes. I ended up changing them to non-static public member functions. I trust your guys will come up with the right solution to fix it.
An enhancement request for your consideration:
Add a hook to allow store owners to add QR code, or other related info. as they see fit through the hook under the following code (line 63 in affiliate_creative_list.php.) QR code is becoming common with the fast expanding mobile users.
<h3><?php _e(‘Your Affiliate Link Using Affiliate ID’, ‘affiliates-manager’) ?></h3>
<textarea class=”wpam-creative-code” rows=”1″><?php echo $alink_id; ?></textarea>I’ll be providing the Simplified Chinese translation files that we have come up with later after the tests are done.
Thank you guys for the plugin!
JimJune 1, 2018 at 2:36 am #3659Jim
ParticipantFound a couple more on email subjects not i18N ready (fixed code pasted):
1. line 105 of CommissionTracking.php: $subject = __(“You just earned a commission!”, ‘affiliates-manager’);
2. line 50 of EmailHandler.php: $subject = sprintf(__(“Affiliate Application for %s”, ‘affiliates-manager’), $blogname);June 2, 2018 at 10:26 pm #3663mbrsolution
ModeratorThank you for reporting this. I have submitted a message to the developers to investigate further your findings.
Kind regards
-
AuthorPosts
- You must be logged in to reply to this topic.